Custom domains for [JitPack] artifacts #8333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris48s
reviewed
Aug 21, 2022
| dateAdded: new Date('2019-03-31'), | ||
| }), | ||
| redirector({ |
There was a problem hiding this comment.
The reason the tests are failing is:
Error: Duplicate service names found: {
"JitpackVRedirect": 2
}
we'll need to manually give each of these redirects a unique name when we declare them as the auto-generated names are clashing.
https://github.com/badges/shields/blob/master/core/base-service/redirector.js#L46-L50
You can run npm test locally to run the core tests and liners
There was a problem hiding this comment.
Thank you; I couldn't get npm install to work... I've fixed it and was finally able to test the code.
Comment on lines
13
to
+15
| static route = { | ||
| base: 'jitpack/v', | ||
| pattern: ':vcs(github|bitbucket|gitlab|gitee)/:user/:repo', | ||
| base: 'jitpack/version', | ||
| pattern: ':groupId/:artifactId', |
There was a problem hiding this comment.
Lets leave a comment linking to #8312 to explain why we're using /version rather than /v here.
Comment on lines
+13
to
+15
| t.create('jitpack version redirect (github)') | ||
| .get('/github/jitpack/maven-simple.svg') | ||
| .expectRedirect('/jitpack/version/com.github.jitpack/maven-simple.svg') |
chris48s
approved these changes
Aug 22, 2022
|
cheers - merging with slightly tweaked names |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #8312
Introduced a new
jitpack/versionendpoint:jitpack/vredirects to it, either with no VCS (still defaulting to GitHub), or with a VCS previously supported.It uses the full
groupIdfrom jitpack as input (usuallycom.github.user, but custom domains, likeio.jitpack, as well).