Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix [dockerstars] service #8316

Merged
merged 1 commit into from
Aug 17, 2022
Merged

fix [dockerstars] service #8316

merged 1 commit into from
Aug 17, 2022

Conversation

chris48s
Copy link
Member

closes #8314

@chris48s chris48s added bug Bugs in badges and the frontend service-badge New or updated service badge labels Aug 17, 2022
@shields-ci
Copy link

Warnings
⚠️ This PR modified service code for docker but not its test code.
That's okay so long as it's refactoring existing code.
Messages
📖 ✨ Thanks for your contribution to Shields, @chris48s!

Generated by 🚫 dangerJS against 29baf0b

calebcartwright
calebcartwright approved these changes Aug 17, 2022
View reviewed changes
Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still unclear, and mildly concerned, about what happened upstream, but definitely agreed with the direction here 👍

@calebcartwright calebcartwright merged commit 35700ba into badges:master Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebcartwright calebcartwright calebcartwright approved these changes

Assignees
No one assigned
Labels
bug Bugs in badges and the frontend service-badge New or updated service badge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Docker stars broken (invalid) ⭐
3 participants
@chris48s @shields-ci @calebcartwright