-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add [galaxytoolshed] services #8114
Add [galaxytoolshed] services #8114
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your patience, persistence, and breaking up the original PR as this is much easier to review and discuss!
I think the bones of this are in place, but there's a few changes I'd like to see and a couple questions I've left inline below
Puzzled by the CI failure so changing the title to test some things |
CI should be fixed. Can you rebase your branch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple minor cleanup items, but happy to approve and merge after they are taken care of!
It's going to be tricky getting this merged because it's coming from an Organization-owned fork. We have a branch protection policy in place that requires the source branch be up to date with the target before PRs can be merged. We utilize bots and automation which make this seamless for most contributors, but GitHub doesn't allow PRs from Org forks to enable write access to the upstream maintainers (and their bots). This means we'll likely have to try to coordinate a squash/merge update and approval to happen at the same time, as any time any other PR is merged in this repo it'll reset yours back to an unmergable, out-of-date state |
If I open a new PR, the same as this PR, with a fork coming from my personal account, can be helpful ? |
If you can go ahead and update this one shortly then we can probably get it resolved. For future PRs though yes it would definitely be worth considering submitting them from a personal fork |
Thank you so much ! |
This PR refers to the PR #7633 and the issue #7660 suggesting one feature, get the number of downloads for a repository, for a new service
galaxytoolshed
.Many thanks