-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shields.io doesn't work at all on Safari 15.2, macOS Monterey #7447
Comments
This looks like it is related to, or possibly a duplicate of #7324 I don't use a mac so I can't confirm or reproduce this. I'm going to leave it tagged "question" for the moment pending a confirmation but I'm marking it "good first issue" as it would be really useful to get some help from the wider community on these Apple-specific issues. |
@chris48s I don't know how much I can help with the fix, but I can certainly gather more info (debug console messages, for example) if needed. As a starting point, can you tell me which platforms and browsers shields.io is tested on? |
We run our frontend tests using cypress which is Chrome-based. My theory is that this issue is caused by sindresorhus/decamelize#36 after upgrading decamelize in #7098 I've submitted a PR over at #7449 to revert decamelize to version 5. I have no way of testing this myself but is someone who has an i-Device of some description able to check the staging deploy at https://shields-staging-pr-7449.herokuapp.com/ and see if that fixes it in Safari? The staging deploy is on a dyno that goes to sleep so it might take a while to load |
My Safari is 14.1.2 which works fine on https://shields.io/ and https://shields-staging-pr-7449.herokuapp.com/, so I can't verify this one way or another. |
Ditto. I know there are services out there that facilitate the execution of UI/functional style testing against various platform/browser matrices, but we definitely don't have anything like that in place and likely wouldn't have the budget for such a service anyway (though I imagine a few offer some free credits for open source) |
@chris48s Unfortunately, this doesn't work on Safari 15.2 either. Same behaviour as the production shields.io, I'm afraid. :( |
I can confirm this bug on Safari 15.2 (17612.3.6.1.6). Problem was introduced in 0854e90 and the last working commit is 8fcdb76. I found it using Unfortunately Cypress does not support Safari, so I used https://playwright.dev instead.
import { test, expect } from '@playwright/test';
test('basic test', async ({ page }) => {
await page.goto('http://localhost:3000/');
await page.click('a[href="/category/build"]');
const pageTest = page.locator('body');
await expect(pageTest).toContainText('/appveyor/build/:user/:repo');
});
#!/bin/sh
set -x
git --no-pager show --name-only
rm -rf node_modules
git checkout -- .
npm i
npm i -D @playwright/test
npm i -D start-server-and-test
git checkout -- .
./node_modules/.bin/start-server-and-test 'npm start' 3000 'npx playwright test --browser webkit playwright-test.spec.ts' and finally: $ git bisect start HEAD 5a982f62e7e3077b0e16d122d4adb0229e037632
$ git bisect run ./test.sh
# [...]
0854e90e9037e7398cc929502b1c74295c1702d5 is the first bad commit |
New staging deploy up. Can we try this one? |
Works perfectly (Safari 15.2 (17612.3.6.1.6)). |
Are you experiencing an issue with...
shields.io
🐞 Description
Safari: Version 15.2 (17612.3.6.1.6)
macOS: Monterey 12.1
I tried disabling all browser extensions in Safari, to no effect.
I tried restarting Safari, to no effect.
The web inspector console shows the following errors & warnings.
🔗 Link to the badge
No response
💡 Possible Solution
No response
The text was updated successfully, but these errors were encountered: