upgrade to node 16 #7271
Merged
upgrade to node 16 #7271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris48s
added
the
operations
|
chris48s
commented
Nov 14, 2021
| docker: | ||
| - image: circleci/node:16 | ||
| - image: circleci/node:17 |
There was a problem hiding this comment.
I don't think we should actually aim to deploy on Node 17 at any point. There won't be a node 18 build available until April 2022 but I reckon me might as well keep a 'next' build in play and then switch it to 18 next year.
|
Assuming this gets approved, we'll need to update the branch protection rules to merge it |
calebcartwright
approved these changes
Nov 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7130