Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: githubApiProvider.request is not a function #7214

Closed
sentry-io bot opened this issue Nov 1, 2021 · 2 comments · Fixed by #7215
Closed

TypeError: githubApiProvider.request is not a function #7214

sentry-io bot opened this issue Nov 1, 2021 · 2 comments · Fixed by #7215
Assignees
Labels
bug Bugs in badges and the frontend service-badge New or updated service badge

Comments

@sentry-io
Copy link

sentry-io bot commented Nov 1, 2021

Sentry Issue: SHIELDS-73

TypeError: githubApiProvider.request is not a function
  File "/app/services/php-version.js", line 237, in request
    githubApiProvider.request(request, url, {}, cb),
  File "/app/core/legacy/regular-update.js", line 44, in regularUpdate
    request(url, options, (err, res, buffer) => {
  ?, in new Promise
  File "/app/services/php-version.js", line 221, in getPhpReleases
    return promisify(regularUpdate)({
  File "/app/services/travis/travis-php-version.service.js", line 83, in TravisPhpVersion.transform
    await getPhpReleases(this._githubApiProvider)
...
(5 additional frame(s) were not displayed)
@chris48s
Copy link
Member

chris48s commented Nov 1, 2021

Broken by #7212

@chris48s chris48s added bug Bugs in badges and the frontend service-badge New or updated service badge labels Nov 1, 2021
@chris48s chris48s self-assigned this Nov 1, 2021
@chris48s
Copy link
Member

chris48s commented Nov 1, 2021

So it turned out the fix for this bug is to do almost all of the remaining work on #4655 Fortunately I was planning on doing it soon anyway 😄 I have an unfinished but mostly working stab at this locally. Should be able to submit a PR in the next couple of days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs in badges and the frontend service-badge New or updated service badge
Projects
None yet
1 participant