use got to push influx metrics

[chris48s]

refs #4655

Nice bit of low hanging fruit here 🍏
Because this is stand-alone utility code and not part of the services I haven't routed it through fetchFactory/sendRequest. I've just gone straight from request to got.

[shields-ci]

	Messages
📖	✨ Thanks for your contribution to Shields, @chris48s!

Generated by 🚫 dangerJS against 2eab29a

[calebcartwright]

One question for my own edification, but LGTM

[calebcartwright]

this just prevents got from throwing on some non-successful response status code right?

[chris48s]

Yep. By default got throws an exception if it gets a 404, 500 or whatever. This tells it to return a response. I mainly did this because the existing error handling code assumes this behaviour from request, but I could have rewritten the error handling code here

shields/core/server/influx-metrics.js

Lines 33 to 45 in fd7eddc

	} catch (error) {
	log.error(
	new Error(`Cannot push metrics. Cause: ${error.name}: ${error.message}`)
	)
	}
	if (response && response.statusCode >= 300) {
	log.error(
	new Error(
	`Cannot push metrics. ${response.request.href} responded with status code ${response.statusCode}`
	)
	)
	}
	}

to handle both cases in the catch block instead. I don't think it makes much difference either way though.