Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move remaining hostnames from route params to query params #4178

Closed
3 tasks done
calebcartwright opened this issue Oct 14, 2019 · 3 comments · Fixed by #4390
Closed
3 tasks done

Move remaining hostnames from route params to query params #4178

calebcartwright opened this issue Oct 14, 2019 · 3 comments · Fixed by #4390
Assignees
Labels
service-badge New or updated service badge

Comments

@calebcartwright
Copy link
Member

calebcartwright commented Oct 14, 2019

A follow up to #3714 with the last services that still have url/server/host parameters specified as route params instead of query params:

I think that's all of them but if anyone sees any others please update this list/leave a comment

@calebcartwright calebcartwright added the service-badge New or updated service badge label Oct 14, 2019
@paulmelnikow
Copy link
Member

Thanks for opening this.

For what it’s worth I don’t mind it on the Observatory badge as it’s just a hostname, and thus fits nicely into the URL. Though if you prefer to make them all query params I could get behind that.

@calebcartwright
Copy link
Member Author

For what it’s worth I don’t mind it on the Observatory badge as it’s just a hostname, and thus fits nicely into the URL.

Ah okay, I didn't actually look that closely 😄

Though if you prefer to make them all query params I could get behind that.

WFM

@PyvesB
Copy link
Member

PyvesB commented Nov 24, 2019

Will pick up the Jenkins badges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service-badge New or updated service badge
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants