You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With the currently hard-coded white text I think most badges pick a darker colours so that there is enough contrast to the text.
We could do something similar that was done for #2431 wrt. logos, choosing black or white text based on a luminance calculation for the background colour.
Perhaps part of the role of the shadow is to give the text at least some very faint outline in the case of a light background. If so, maybe it should be removed or changed in the case of black text.
The text was updated successfully, but these errors were encountered:
A concern with this is of course that it can change the rendering of existing badges (hopefully for the better), so it would be good to be able to see the impact on existing badges doing this.
I'd lean against automatically choosing a light color for uniformity's sake, though we could implement #504 to make this possible for people who really need to use light colors and want dark text.
With the currently hard-coded white text I think most badges pick a darker colours so that there is enough contrast to the text.
We could do something similar that was done for #2431 wrt. logos, choosing black or white text based on a luminance calculation for the background colour.
Perhaps part of the role of the shadow is to give the text at least some very faint outline in the case of a light background. If so, maybe it should be removed or changed in the case of black text.
The text was updated successfully, but these errors were encountered: