Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Badge for another repo queried issues #2568

Closed
apobekiaris opened this issue Dec 20, 2018 · 4 comments
Closed

Badge for another repo queried issues #2568

apobekiaris opened this issue Dec 20, 2018 · 4 comments
Labels
question Support questions, usage questions, unconfirmed bugs, discussions, ideas

Comments

@apobekiaris
Copy link

apobekiaris commented Dec 20, 2018

hi

I generated this badge

[![](https://img.shields.io/github/issues/eXpandFramework/Packages.svg?style=flat-square)](https://github.com/eXpandFramework/eXpand/issues?utf8=%E2%9C%93&q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc+label%3Apackages).

at the moment of posting the query returns 1 issue

image

however the badge displays zero

image
image

@apobekiaris
Copy link
Author

apobekiaris commented Dec 20, 2018

here the solution

[![GitHub issues](https://img.shields.io/github/issues/eXpandFramework/expand/Packages.svg)]

@paulmelnikow
Copy link
Member

paulmelnikow commented Dec 20, 2018

Aha! I wonder if we can improve the error handling there. That's one of the badges which hasn't been refactored yet. It'll probably get examined when that happens.

@paulmelnikow paulmelnikow added the service-badge New or updated service badge label Dec 20, 2018
@apobekiaris
Copy link
Author

though this project is super powerfull it's a bit hard to understand how to configure when you first comer. Maybe you should unit test the examples on the site, or provide more realistic ones that work and not just images.

@paulmelnikow
Copy link
Member

Improving error messages is something we've been working on over the last year or so, though as I look closer at this, I'm not sure we could do any better here. You have a repo in the same org called Packages, which means the badge you asked for is valid. This is the test of the "repo not found" case for that badge:

t.create('GitHub open issues (repo not found)')
.get('/issues-raw/badges/helmets.json')
.expectJSON({
name: 'open issues',
value: 'repo not found',
})

Was the difficulty figuring out how to plug the values into the right place? I'm working on #2496 along those lines, which should make it easier to correctly construct a badge URL from parts.

In case it's helpful to you in the meantime, all of the badges have one fully working example. It's either there from the start, like this one:

example1

Or is listed as a separate Example, like this one:

screen shot 2018-12-20 at 3 35 31 pm

Finally, we're serious about improving this stuff, though we're all volunteers. There are lots of ways you can help: good first issue New contributors, join in!

@paulmelnikow paulmelnikow added question Support questions, usage questions, unconfirmed bugs, discussions, ideas and removed service-badge New or updated service badge labels Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Support questions, usage questions, unconfirmed bugs, discussions, ideas
Projects
None yet
Development

No branches or pull requests

2 participants