Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yaml dynamic badge #1617

Closed
jacobtomlinson opened this issue Mar 28, 2018 · 1 comment · Fixed by #1623
Closed

Add yaml dynamic badge #1617

jacobtomlinson opened this issue Mar 28, 2018 · 1 comment · Fixed by #1623
Labels
good first issue New contributors, join in! service-badge New or updated service badge

Comments

@jacobtomlinson
Copy link
Contributor

The json and xml dynamic badges are awesome. It would be great to add yaml to the list of supported markups.

One initial use case I can think of would be for helm chart repos to show the latest version of a chart.

@paulmelnikow paulmelnikow added the service-badge New or updated service badge label Mar 28, 2018
@paulmelnikow
Copy link
Member

Great idea!

Would you be interested in making a pull request? We have a good tutorial, and since the JSON badge is already built, it's probably a matter of conditioning on json vs yaml in the URL, adding js-yaml to handle parsing, and adding some tests. If not, maybe someone else would like to pick this up!

@paulmelnikow paulmelnikow added the good first issue New contributors, join in! label Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue New contributors, join in! service-badge New or updated service badge
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants