Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node version badge show wrong number #1447

Closed
elvinn opened this issue Jan 15, 2018 · 2 comments
Closed

Node version badge show wrong number #1447

elvinn opened this issue Jan 15, 2018 · 2 comments
Labels
question Support questions, usage questions, unconfirmed bugs, discussions, ideas

Comments

@elvinn
Copy link

elvinn commented Jan 15, 2018

[![node](https://img.shields.io/node/v/passport.svg)](https://github.com/elvinn/git-master-merged)

I add a node version badge to my project. Although I set engines.node value as >= 6.0.0 in package.json, the badge shows >= 0.4.0.

Is my usage wrong? Will shields.io parse engines.node to generate the badge?

Thanks a lot!

@chris48s
Copy link
Member

The badge URL you've used is for someone else's project. It reports the correct value for passport :)

The badge URL for your project is https://img.shields.io/node/v/git-master-merged.svg

At the moment it will show 'not specified' because it gets the node compatibility info from NPM, not GitHub. The version of git-master-merged on NPM doesn't haveengines.node. It will update when you next publish your package to NPM.

@elvinn
Copy link
Author

elvinn commented Jan 16, 2018

It works out. Thanks for your reply 😺

@elvinn elvinn closed this as completed Jan 16, 2018
@paulmelnikow paulmelnikow added the question Support questions, usage questions, unconfirmed bugs, discussions, ideas label Jan 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Support questions, usage questions, unconfirmed bugs, discussions, ideas
Projects
None yet
Development

No branches or pull requests

3 participants