Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stars in badges broken (staging server misses font) #1309

Closed
tooomm opened this issue Dec 1, 2017 · 4 comments
Closed

Stars in badges broken (staging server misses font) #1309

tooomm opened this issue Dec 1, 2017 · 4 comments
Labels
developer-experience Dev tooling, test framework, and CI

Comments

@tooomm
Copy link
Contributor

tooomm commented Dec 1, 2017

@paulmelnikow
Copy link
Member

This is a problem with the staging server, which does not have the correct font installed. As a result the text width computation is off. The stars do look especially bad. If you look closely, nearly all the badges are a bit off.

Agree it would be nice to fix this.

@paulmelnikow paulmelnikow added the developer-experience Dev tooling, test framework, and CI label Dec 2, 2017
@tooomm tooomm changed the title Stars in badges broken Stars in badges broken (staging only) Dec 2, 2017
@tooomm
Copy link
Contributor Author

tooomm commented Dec 2, 2017

If you look closely, nearly all the badges are a bit off (on staging server).

This is hard to tell since all badges on live shields.io page look a bit off on former Firefox versions anyway. :)

@tooomm tooomm changed the title Stars in badges broken (staging only) Stars in badges broken (staging server misses font) Dec 2, 2017
@espadrine
Copy link
Member

The right font is from the Mac's Verdana TTF. Unfortunately, for licensing issues, we cannot transmit it.

@paulmelnikow
Copy link
Member

I'm delighted to say this was fixed in #2311!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer-experience Dev tooling, test framework, and CI
Projects
None yet
Development

No branches or pull requests

3 participants