New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to load sketches into memory using python API #15

Open

johnlees opened this issue Jan 30, 2020 · 1 comment

Assignees

Labels

Member

johnlees commented Jan 30, 2020

Useful for repeated queries, as otherwise they would have to be loaded from HDF5 each time

johnlees added the enhancement label

johnlees self-assigned this

Member Author

johnlees commented Sep 30, 2020

See: https://pybind11.readthedocs.io/en/stable/advanced/cast/stl.html#making-opaque-types
We can then write functions which return this type to python for finer control:

create DB, which returns a vector of Reference
load sketches (from a HDF5 db); returns vector of Reference
save sketches (to a HDF5 db); takes vector of Reference
query, which takes two vectors of Reference

The current query DB function will be rewritten as load + query
The current create DB function will be rewritten as create + save

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment