From ddb47889766869920a2780ec75466cde9ffe565c Mon Sep 17 00:00:00 2001
From: Paul <baconpaul@users.noreply.github.com>
Date: Sat, 16 Jul 2022 09:22:06 -0400
Subject: [PATCH] Maintain LFO phase constraint in mseg node delete (#6370)

We have to explicitly maintain the endpoint constraint and
rebuild when deleting in MSEG LFO mode. Without it the last
node ended up obviously wrong.

Closes #6349
---
 .../dsp/modulators/MSEGModulationHelper.cpp       | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/src/common/dsp/modulators/MSEGModulationHelper.cpp b/src/common/dsp/modulators/MSEGModulationHelper.cpp
index 3d94230b288..7f47f2f2476 100644
--- a/src/common/dsp/modulators/MSEGModulationHelper.cpp
+++ b/src/common/dsp/modulators/MSEGModulationHelper.cpp
@@ -1125,6 +1125,21 @@ void deleteSegment(MSEGStorage *ms, int idx)
 
     ms->n_activeSegments--;
 
+    if (ms->editMode == MSEGStorage::LFO)
+    {
+        // We need to fill up the last one to span.
+        auto ei = ms->n_activeSegments - 1;
+        ms->segmentEnd[ei] = 1.0;
+        auto cd = 0.f;
+        for (int i = 0; i < ei; ++i)
+            cd += ms->segments[i].duration;
+
+        ms->segments[ei].duration = 1.0 - cd;
+        ms->segments[ei].cpduration += 1.0 - cd;
+
+        rebuildCache(ms);
+    }
+
     if (ms->loop_start > idx)
     {
         ms->loop_start--;