From 8d2fea2d5fe044361a8b203656103c9c81ed77ed Mon Sep 17 00:00:00 2001
From: Paul Walker <paul@pwjw.com>
Date: Wed, 24 May 2023 11:38:03 -0400
Subject: [PATCH] Fix Bonsai ParamMetaData to match the surge ranges

Closes https://github.com/surge-synthesizer/surge/issues/7031
---
 libs/sst/sst-effects                       |  2 +-
 src/common/dsp/effects/SurgeSSTFXAdapter.h | 10 +++-------
 2 files changed, 4 insertions(+), 8 deletions(-)

diff --git a/libs/sst/sst-effects b/libs/sst/sst-effects
index bbac50be9ab..6520c2ec845 160000
--- a/libs/sst/sst-effects
+++ b/libs/sst/sst-effects
@@ -1 +1 @@
-Subproject commit bbac50be9abefecf445a9e14585be48690ec4b2c
+Subproject commit 6520c2ec845577c21b1c73003ea6c67328922f0f
diff --git a/src/common/dsp/effects/SurgeSSTFXAdapter.h b/src/common/dsp/effects/SurgeSSTFXAdapter.h
index 9afd78bccee..7fba506043c 100644
--- a/src/common/dsp/effects/SurgeSSTFXAdapter.h
+++ b/src/common/dsp/effects/SurgeSSTFXAdapter.h
@@ -210,10 +210,10 @@ template <typename T> struct SurgeSSTFXBase : T
             }
             this->fxdata->p[i].set_name(pmd.name.c_str());
             this->fxdata->p[i].basicBlocksParamMetaData = pmd;
-            auto check = [&](auto a, auto b, auto msg) {
+            auto check = [&, i](auto a, auto b, auto msg) {
                 if (a != b)
-                    std::cout << "Unable to match " << pmd.name << " " << a << " " << b << " "
-                              << msg << std::endl;
+                    std::cout << "Metadata Mismatch (" << msg << "): param[" << i << "]='" << pmd.name << "'; paramValue=" << a << " expected=" << b
+                              << std::endl;
             };
             if (pmd.type == sst::basic_blocks::params::ParamMetaData::Type::FLOAT)
             {
@@ -225,10 +225,6 @@ template <typename T> struct SurgeSSTFXBase : T
                 check((int)pmd.minVal, this->fxdata->p[i].val_min.i, "Minimum Values");
                 check((int)pmd.maxVal, this->fxdata->p[i].val_max.i, "Maximum Values");
             }
-            if (!pmd.supportsStringConversion)
-            {
-                std::cout << "No support for string conversion on " << pmd.name << std::endl;
-            }
             check(pmd.canTemposync, this->fxdata->p[i].can_temposync(), "Can Temposync");
             check(pmd.canDeform, this->fxdata->p[i].has_deformoptions(), "Can Deform");
             check(pmd.canAbsolute, this->fxdata->p[i].can_be_absolute(), "Can Be Absolute");