Fix a failure-path memory leak in PatchDB (surge-synthesizer#5269)

Closes surge-synthesizer#5268
baconpaul · Oct 17, 2021 · 6e464c6 · 6e464c6
1 parent bc65649
commit 6e464c6
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/src/common/PatchDB.cpp b/src/common/PatchDB.cpp
@@ -460,6 +460,13 @@ CREATE TABLE IF NOT EXISTS Favorites (
             // clean up all the prepared statements
             if (dbh)
                 sqlite3_close(dbh);
+            dbh = nullptr;
+        }
+
+        if (rodbh)
+        {
+            sqlite3_close(rodbh);
+            rodbh = nullptr;
         }
     }
 
@@ -973,6 +980,8 @@ CREATE TABLE IF NOT EXISTS Favorites (
                         << "'. The error was '" << sqlite3_errmsg(dbh) << "'.";
                     storage->reportError(oss.str(), "Surge Patch Database Error");
                 }
+                if (rodbh)
+                    sqlite3_close(rodbh);
                 rodbh = nullptr;
             }
         }