Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for postgres scenarios where external secret is involude #155

Closed
tumido opened this issue Dec 1, 2023 · 3 comments · Fixed by #193
Closed

Add tests for postgres scenarios where external secret is involude #155

tumido opened this issue Dec 1, 2023 · 3 comments · Fixed by #193
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@tumido
Copy link
Member

tumido commented Dec 1, 2023

I get scared when I see postgres auth secret values getting changed 😆, mainly because of past stress of trying to satisfy all of the scenarios that tend to cause regression to other values if not done right. Do we have good tests to ensure that when certain values are set, the correct Deployment yaml is generated? As theres a few conditional branches in that backstage.postgresql.databaseSecretKey function. If not, would be good to get these in another time if possible. Will allow us to change any code in this area with increased confidence in future.

I will add though, changes lgtm 👍

Originally posted by @ChrisJBurns in #154 (comment)

@tumido tumido added good first issue Good for newcomers help wanted Extra attention is needed labels Dec 1, 2023
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Feb 29, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 8, 2024
@ChrisJBurns ChrisJBurns reopened this Mar 8, 2024
@ChrisJBurns ChrisJBurns self-assigned this Mar 8, 2024
@github-actions github-actions bot removed the stale label Mar 9, 2024
Copy link

github-actions bot commented May 9, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label May 9, 2024
@ChrisJBurns
Copy link
Contributor

Remove stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants