Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove shortcut module from core #76

Closed
jenlampton opened this issue Sep 14, 2013 · 5 comments
Closed

Remove shortcut module from core #76

jenlampton opened this issue Sep 14, 2013 · 5 comments
Milestone

Comments

@jenlampton
Copy link
Member

No description provided.

@hosef
Copy link

hosef commented Sep 22, 2013

I actually like this module, and use it to list frequently used pages for people using my sites.

If we really do want to take it out, then it should go into contrib. I guess I can take over it in that case, but we should probably figure out how we are going to handle contrib for backdrop.

@chrisfromredfin
Copy link

+1 that I do like it, but I would also accept it as contrib.

@luiselizondo
Copy link

All tests are OK

@quicksketch
Copy link
Member

Thanks guys. Yeah support for shortcut in contrib would be great demonstrations of extending the toolbar. We're not sure where we're going to head with the toolbar integration (e.g. the mobile implementation, adding search or dropdowns like admin_menu... there's a lot unknowns). But for Backdrop core, I feel like shortcuts are an often confusing and rarely understood feature. So I'm in favor of removing too.

How we handle contrib is still being worked out. For those interested I'd suggest following this issue in the BackdropCMS.org queue: backdrop-ops/backdropcms.org#8

@quicksketch
Copy link
Member

Merged backdrop/backdrop#70. Thanks so much @luiselizondo! You're a module-removing machine. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants