Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document equivalent function to deprecated file_create_htaccess(). #6665

Closed
argiepiano opened this issue Jul 26, 2024 · 3 comments · Fixed by backdrop/backdrop#4837
Closed

Document equivalent function to deprecated file_create_htaccess(). #6665

argiepiano opened this issue Jul 26, 2024 · 3 comments · Fixed by backdrop/backdrop#4837
Assignees
@argiepiano
Labels
status - has pull request type - documentation
Milestone
1.28.3

Comments

@argiepiano
Copy link

file_create_htaccess is provided by the Drupal compatibility layer, and is deprecated. The Backdrop equivalent is file_save_htaccess. It'd be good to document this in the docblock for file_create_htaccess, like other deprecated functions in that file.

Backdrop version: 1.28.2
@argiepiano argiepiano mentioned this issue Jul 26, 2024
Merged
@argiepiano
Copy link
Author

PR backdrop/backdrop#4837 available for review

@klonos klonos added this to the 1.28.3 milestone Jul 26, 2024
@klonos klonos changed the title Document equivalent function to deprecated file_create_htaccess() [DX] Document equivalent function to deprecated file_create_htaccess() Jul 26, 2024
@klonos
Copy link
Member

klonos commented Jul 26, 2024

Thanks @argiepiano 🙏🏼 ...RTBC 👍🏼

backdrop-ci referenced this issue in backdrop/backdrop Aug 30, 2024
@argiepiano
Issue #6665: Add documentation to deprecated file_create_htaccess().
4a6ba47 
By @argiepiano and @klonos.
backdrop-ci referenced this issue in backdrop/backdrop Aug 30, 2024
@argiepiano @quicksketch
Issue #6665: Add documentation to deprecated file_create_htaccess().
9b45a09 
By @argiepiano and @klonos.
@quicksketch
Copy link
Member

Thanks @argiepiano and @klonos! Merged backdrop/backdrop#4837 into 1.x and 1.28.x.

@jenlampton jenlampton changed the title [DX] Document equivalent function to deprecated file_create_htaccess() Document equivalent function to deprecated file_create_htaccess(). Sep 15, 2024
@jenlampton jenlampton mentioned this issue Sep 16, 2024
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@argiepiano argiepiano

Labels
status - has pull request type - documentation
Projects
None yet
Milestone
1.28.3
Development

Successfully merging a pull request may close this issue.

Issue 6665. Add documentation to deprecated file_create_htaccess argiepiano/backdrop
3 participants
@quicksketch @klonos @argiepiano