Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Rephrase "database updates" so that it is clear that they also perform config updates. #5630

Closed
laryn opened this issue May 17, 2022 · 13 comments · Fixed by backdrop/backdrop#4642

Comments

@laryn
Copy link
Contributor

laryn commented May 17, 2022

It seems that perhaps the process that is currently labeled "Backdrop database update" (/core/update.php) could be named more accurately. This process includes any update hook at all, and may include or be exclusively config updates, for example. Should we consider changing this term/phrase?

@olafgrabienski
Copy link

Good idea! As a start, we could list places and term variations which refer to the (former) database update.

@indigoxela
Copy link
Member

indigoxela commented May 18, 2022

... may include or be exclusively config updates, for example. Should we consider changing this term/phrase?

I think about that almost every time I run "database updates" - when I know, that it's actually config. Yes, let's be more accurate about that. 👍

@olafgrabienski
Copy link

list places and term variations which refer to the (former) database update

Here's a start:

  • database update
  • database updates
  • run updates (e.g. Admin bar)

@bugfolder
Copy link

How about "Backdrop site update"?

@bugfolder
Copy link

Here's a PR that changes "database update" to "site update" in most places (unless we're actually only changing the database).

@laryn
Copy link
Contributor Author

laryn commented Jan 26, 2024

I looked over the changes and the code looks good.

@stpaultim
Copy link
Member

This change makes sense to me.

@olafgrabienski
Copy link

I also like the direction!

@bugfolder Can you also mention configuration files in the first sentence on core/update.php?

Use this utility to update your database whenever you install a new version of Backdrop CMS or one of the site's modules.

@bugfolder
Copy link

Can you also mention configuration files in the first sentence on core/update.php?

I changed it from "update your database" to "update your site", similarly to other changes. That block of text also mentions "This update utility will alter your database and config files," so config does get mentioned.

I notice that all of that text is not wrapped in t(), which I assume is for a good reason; I'm just curious as to why.

@klonos klonos changed the title Rephrase "Backdrop database update"? [UX ]Rephrase "database updates" so that it is clear that they also perform config updates. Jun 16, 2024
@klonos klonos changed the title [UX ]Rephrase "database updates" so that it is clear that they also perform config updates. [UX] Rephrase "database updates" so that it is clear that they also perform config updates. Jun 16, 2024
@klonos
Copy link
Member

klonos commented Jun 16, 2024

Coming late to this: Yes please! 👍🏼 💯

The phrase "System updates" is already reserved for the core version updates, as well as contrib and customer project updates under Configuration >> System >> System updates (admin/config/system/updates). So "site updates" seems sensible/appropriate to me too.

The PR needs a rebase and has conflicts that will need to be resolved.

@klonos
Copy link
Member

klonos commented Jun 16, 2024

I notice that all of that text is not wrapped in t(), which I assume is for a good reason; I'm just curious as to why.

I am also not 100% sure about that, but when I've asked previously, I think that the answer was that t() might not be loaded during that stage. It could be an oversight though 🤷🏼

@herbdool
Copy link

herbdool commented Jun 16, 2024

I've reviewed the code and tested (after rebasing). Looks good now.

@quicksketch
Copy link
Member

Awesome, that's a lot of agreement for a string change! I merged backdrop/backdrop#4642 into 1.x and 1.28.x. Thanks @bugfolder, @laryn, @herbdool, @olafgrabienski, @klonos, and @indigoxela!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants