-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UX] Rephrase "database updates" so that it is clear that they also perform config updates. #5630
Comments
Good idea! As a start, we could list places and term variations which refer to the (former) database update. |
I think about that almost every time I run "database updates" - when I know, that it's actually config. Yes, let's be more accurate about that. 👍 |
Here's a start:
|
How about "Backdrop site update"? |
Here's a PR that changes "database update" to "site update" in most places (unless we're actually only changing the database). |
I looked over the changes and the code looks good. |
This change makes sense to me. |
I also like the direction! @bugfolder Can you also mention configuration files in the first sentence on
|
I changed it from "update your database" to "update your site", similarly to other changes. That block of text also mentions "This update utility will alter your database and config files," so config does get mentioned. I notice that all of that text is not wrapped in |
Coming late to this: Yes please! 👍🏼 💯 The phrase "System updates" is already reserved for the core version updates, as well as contrib and customer project updates under Configuration >> System >> System updates ( The PR needs a rebase and has conflicts that will need to be resolved. |
I am also not 100% sure about that, but when I've asked previously, I think that the answer was that |
I've reviewed the code and tested (after rebasing). Looks good now. |
…and documentation. By @bugfolder, @laryn, @klonos, @stpaultim, @olafgrabienski, @herbdool and @indigoxela.
…and documentation. By @bugfolder, @laryn, @klonos, @stpaultim, @olafgrabienski, @herbdool and @indigoxela.
Awesome, that's a lot of agreement for a string change! I merged backdrop/backdrop#4642 into 1.x and 1.28.x. Thanks @bugfolder, @laryn, @herbdool, @olafgrabienski, @klonos, and @indigoxela! |
It seems that perhaps the process that is currently labeled "Backdrop database update" (/core/update.php) could be named more accurately. This process includes any update hook at all, and may include or be exclusively config updates, for example. Should we consider changing this term/phrase?
The text was updated successfully, but these errors were encountered: