Fixed: PHP 8: Views Handlers: Filter: in_operator - Array to string conversion

[indigoxela]

Description of the bug

Part of #5076

Failing tests with PHP 8:

---- Views Handlers: Filter: in_operator (ViewsHandlerFilterInOperator) ----

Status    Group      Filename          Line    Function                            
---------------------------------------------------------------------------------------------------
Exception Warning    views.module      1888                                                                            
    Array to string conversion
...

Reason: str_replace() chokes on nested array in $condition['value']

Related Drupal commit and issue

https://git.drupalcode.org/project/views/-/commit/75ea48e0e6bdae213c960090a0c8aea46db0c69a

https://www.drupal.org/project/views/issues/3207982

There are additional changes in that commit.

1. Small change in function postComment - not necessary in Backdrop, but doesn't do any harm (the actual functionality has been fixed for Backdrop in initial PHP 8 support PR.
2. Field test enhancement, which does not belong to the in_operator fix, but to Fixed: PHP 8: Views Plugins: Cache / Views fields for Field API #5314 - without that other fix, the test would fail, so moving the changes over there

[indigoxela]

A PR is available for review. The ViewsHandlerFilterInOperator test is green now with PHP 8.

[klonos]

There are additional changes for code, that doesn't exist in Backdrop.

Yes they exist - just moved elsewhere in Backdrop: indigoxela/backdrop#3

[indigoxela]

Yes they exist - just moved elsewhere in Backdrop:

Ah, there they are, thanks for the hint. 👍

I'm a bit unhappy with your unrelated changes. Especially in function view_comment_user_uid().

[indigoxela]

Hm, strange, a small part solves a failing test in Drupal, but that test passes in Backdrop. Need to take a closer look - with a fresh mind (not today). (CommentViewsHandlerArgumentUserUidTest)

[klonos]

I'm a bit unhappy with your unrelated changes

Yes, the entire file was less than 100 lines, and I felt that it could be tidied up comment-wise (comments exceeding 80 characters, missing periods at the end of comments, a comment on the same line as the thing it's describing, using C style comments which is discouraged etc.).

Sure, feel free to revert those. But I have a feeling that these coding standard violations will never get fixed if we don't gradually fix the files we touch. ...I for one would not be bothered to file a separate issue/PR for them 🤷🏼

Hm, strange, a small part solves a failing test in Drupal, but that test passes in Backdrop. Need to take a closer look - with a fresh mind (not today).

Sure. Rest up 👍🏼

[indigoxela]

Riddles solved, issue description updated, back to "needs review".

@klonos I did a little less cleanup, only in the function that actually changes, to not bloat the PR.

[klonos]

...I did a little less cleanup...

I can live with that 🙂 ...RTBC 👍🏼

[indigoxela]

The PHP version in GHA has been reset to 7.4, ready for merge.

[quicksketch]

Excellent, thank you @indigoxela! I merged backdrop/backdrop#3799 into 1.x and 1.20.x.