-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed: Typos in README.md #5119
Comments
@sg7801 Now I get it, there was no pre-existing issue for that, you acted proactively. 😼 |
I directly came to the project and saw errors in documentation, hence I started contributing by correcting the documentation. |
Thanks you @sg7801 🙏🏼 ...please see my comment in the PR re |
@sg7801 - Thanks for jumping in and offering a PR. We appreciate it! |
@sg7801 sorry for the delay and many thanks for your patience. 🙏 Currently your pull request conflicts with existing code, as the README got updated recently. Do you know how to resolve git conflicts? Please let us know, if you need guidance or help. |
@indigoxela I would be great if you would guide me a bit on resolving git conflicts. |
Hm, I just saw that you made the changes in your fork on the 1.x branch - that's impractical in this case. A new PR would be much easier. I don't know which IDE you use, so I give an example for command line, for the whole fork-edit-push-pull_request process.
Time passes, someone was faster, changes to that file already got merged...
Now resolve the conflict:
BUT ... as you did your changes directly on your 1.x branch, you better:
I don't know if that's really helpful, maybe someone else can provide a much easier step-by-step guide. 😀 Again, I'd recommend to start fresh. And this time you work on a branch, so it's easier to add an upstream and get your fork up-to-date with the original repo. |
I think it's ready to be merged. Thank you @sg7801 |
By @sg7801, @indigoxela, @klonos, @BWPanda & @herbdool.
By @sg7801, @indigoxela, @klonos, @BWPanda & @herbdool.
Many thanks to @sg7801 for this issue/PR! Thanks also to @indigoxela, @klonos & @herbdool for the reviews. I've merged backdrop/backdrop#3649 into 1.x and 1.20.x. |
There are some typos in the documentation ( some grammatical errors and some typing mistakes)
The text was updated successfully, but these errors were encountered: