Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] text cleanup on new block administrative label/description #4600

Open
jenlampton opened this issue Sep 3, 2020 · 25 comments · May be fixed by backdrop/backdrop#3287
Open

[UX] text cleanup on new block administrative label/description #4600

jenlampton opened this issue Sep 3, 2020 · 25 comments · May be fixed by backdrop/backdrop#3287

Comments

@jenlampton
Copy link
Member

jenlampton commented Sep 3, 2020

This is a follow-up to #4558 where we introduced the shiny new admin label and description setting for all blocks :)

Current text is as follows:

  • Fieldset title: Admin label
  • Fieldset description:
  • Label label: Admin label
  • Label description: Used to identify the block on layout pages.
  • Description label: Admin description
  • Description description: This text is used only in administrative interfaces. It will not be shown to site visitors. Allowed HTML tags: <a> <em> <strong> <cite> <blockquote> <code> <ul> <ol> <li> <dl> <dt> <dd>

Screen Shot 2020-09-03 at 1 35 57 PM

Proposed text for each:

  • Fieldset title: Administrative interface
  • Fieldset description: This text is used only in administrative interfaces. It will not be shown to site visitors.
  • Label label: Administrative label
  • Label description: Used to identify this block on layout pages.
  • Description label: Administrative description
  • Description description: Allowed HTML tags: <a> <em> <strong> <cite> <blockquote> <code> <ul> <ol> <li> <dl> <dt> <dd>

Screen Shot 2020-09-03 at 1 43 02 PM

Reasoning:

  • Fieldset label applies to both label and description, choose the less specific term Administrative interface
  • I'd like to use the full word Administration instead of Admin wherever possible.
  • The text This text is used only in administrative interfaces. It will not be shown to site visitors. applies to both fields, so move it into fieldset description?

Feedback?


PR: backdrop/backdrop#3287

@jenlampton
Copy link
Member Author

jenlampton commented Sep 3, 2020

I've filed a PR that makes the above changes to the text, but it also changes the text block class to alter the block class admin info fieldset, rather than overwrite it entirely. (This will prevent us from having the same text strings in two places, so if we need to make changes in the future we won't need to remember to get both locations.)

@klonos
Copy link
Member

klonos commented Sep 3, 2020

The text This text is used only in administrative interfaces. It will not be shown to site visitors. applies to both fields, so move it into fieldset description?

Yup, I like that 👍 ...but the same applies to the Used to identify the block on layout pages. bit. Right? So why leave that only as help text for the label only, when it also applies to the description?

If we added that bit to the fieldset, we'd end up with this:

Used to identify the block on layout pages. This text is used only in administrative interfaces. It will not be shown to site visitors.

That's basically what I proposed in #4558: that we move all text that applies to both the label and description in the fieldset instead (except for the allowed HTML tags for description). Slightly tweaked from my proposal there:

This text is not shown to site visitors - only in administrative pages. It can be used to identify this block when multiple variations of it are added on the same layout.

@jenlampton
Copy link
Member Author

jenlampton commented Sep 3, 2020

...but the same applies to the Used to identify the block on layout pages. bit. Right? So why leave that only as help text for the label only, when it also applies to the description?

Interesting, I was thinking that the label was the identifier for the block, but not the description. I guess it could be interpreted either way... I liked having the description text on the label field so that I'd know what to put in it. But I could be convinced that it's self explanatory... :)

@herbdool herbdool modified the milestones: 1.16.3, 1.17.0 Sep 4, 2020
@herbdool
Copy link

herbdool commented Sep 4, 2020

This should be 1.17.0 since the feature was added there.

@olafgrabienski
Copy link

Are both elements only used to identify a block on layout pages? If they're used nowhere else, we wouldn't need the quite abstract term "administrative interfaces".

@quicksketch
Copy link
Member

For reference here's what Views does (which is similar functionality):
image

Though IMO there's very little about the Views approach we'd want to copy.

@jenlampton
Copy link
Member Author

we wouldn't need the quite abstract term "administrative interfaces".

@olafgrabienski would you prefer "the layout administrative interface"? It's more specific, but also more verbose.

@olafgrabienski
Copy link

My idea was to omit the whole "administrative" part. Something like this:

Used to identify the block on layout pages. It will not be shown to site visitors.

@jenlampton
Copy link
Member Author

jenlampton commented Sep 16, 2020

Used to identify the block on layout pages. It will not be shown to site visitors.

The problem I have with layout pages is that it doesn't distinguish between back-end and front-end. My home page is a "layout page", but I don't want my admin-label to be shown to people viewing the home page.

How about something like Used to identify the block when configuring layouts? Remove the concepts of pages and visitors entirely?

Screen Shot 2020-09-15 at 5 24 04 PM

@quicksketch quicksketch modified the milestones: 1.17.0, 1.17.1 Sep 16, 2020
@olafgrabienski
Copy link

olafgrabienski commented Sep 16, 2020

How about something like Used to identify the block when configuring layouts? Remove the concepts of pages and visitors entirely?

I like the direction but there are still some issues:

  • Actually, "configuring" a layout doesn't mean managing blocks but choosing a layout template on pages like admin/structure/layouts/manage/default/configure.
  • How does "when configuring layouts" sound for a native speaker? For me, it sounds a bit awkward (also when I translate it to German).

The problem I have with layout pages is that it doesn't distinguish between back-end and front-end.

Understood! However, I still think a noun would be a good fit. It just seems we don't have a good name for pages like admin/structure/layouts/manage/default (title is the layout name, active tab is "Manage blocks"). Ideas how to call them in this context?

@jenlampton
Copy link
Member Author

jenlampton commented Sep 16, 2020 via email

@jenlampton jenlampton modified the milestones: 1.17.1, 1.17.2 Sep 30, 2020
@ghost ghost added the type - task label Oct 12, 2020
@quicksketch quicksketch modified the milestones: 1.17.2, 1.17.3 Nov 8, 2020
@philsward
Copy link

philsward commented Nov 14, 2020

Two points to bring up:

  1. I did the "wife" test between the current proposed implementation and a proposal to what I feel like, makes a bit more sense (I agree with Jen that Administrative interface" is a mouthful.)

image

The wife said "the first one makes no sense to me". "The second one uses lingo I can understand".

In regards to asking about interface vs options, she said: "I have no idea what it means by interface".

  1. This appears to only transfer to existing blocks. I created a new custom block and was met with the stable text like Admin label, Admin description etc, so this needs to apply as well over to custom blocks.

@philsward
Copy link

Sidenote question: is there an API where core and contribs can call on this "admin interface" so it is uniform across all of Backdrop?

@klonos
Copy link
Member

klonos commented Nov 15, 2020

I like uniformity/consistency with what we have in views. How about this?:

This text will only be displayed on the "Manage blocks" page. It might be useful if you place the same block type twice.

@jenlampton jenlampton modified the milestones: 1.17.3, 1.17.4 Nov 19, 2020
@jenlampton
Copy link
Member Author

jenlampton commented Dec 2, 2022

I thought that the It will not be shown to site visitors. bit was providing value to people that are new to Backdrop and layouts.

I find it confusing as there is no specific definition for "site visitors". It's also redundant because "This text will only be used to identify the block when configuring layouts." already states the opposite. its like saying "the switch is on, it is not off". You don't really need both to get the point across, and since less text creates a less overwhelming experience, I opted to remove the one that was more confusing.

I will rebase :)

@jenlampton jenlampton modified the milestones: 1.23.1, 1.23.2 Dec 2, 2022
@jenlampton jenlampton self-assigned this Dec 2, 2022
@quicksketch quicksketch modified the milestones: 1.23.2, 1.24.1 Jan 15, 2023
@jenlampton jenlampton modified the milestones: 1.24.1, 1.24.2 Mar 15, 2023
@jenlampton jenlampton modified the milestones: 1.24.2, 1.24.3 Apr 19, 2023
@klonos klonos modified the milestones: 1.24.3, 1.25.1 Jun 6, 2023
@quicksketch quicksketch modified the milestones: 1.25.1, 1.25.2 Jun 7, 2023
@quicksketch quicksketch modified the milestones: 1.25.2, 1.26.1 Sep 15, 2023
@quicksketch quicksketch modified the milestones: 1.26.1, 1.26.2 Oct 6, 2023
@quicksketch quicksketch modified the milestones: 1.26.2, 1.26.3 Dec 1, 2023
@quicksketch quicksketch modified the milestones: 1.26.3, 1.26.4 Dec 20, 2023
@quicksketch quicksketch modified the milestones: 1.26.4, 1.27.1 Jan 16, 2024
@quicksketch quicksketch modified the milestones: 1.27.1, 1.27.2 Mar 8, 2024
@herbdool herbdool removed this from the 1.27.2 milestone May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment