Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed: Remove mention of global theme settings from docblock on theme_get_setting(). #451

Closed
docwilmot opened this issue Dec 12, 2014 · 3 comments · Fixed by backdrop/backdrop#3348
Closed

Fixed: Remove mention of global theme settings from docblock on theme_get_setting(). #451

docwilmot opened this issue Dec 12, 2014 · 3 comments · Fixed by backdrop/backdrop#3348
Labels
status - fixed type - task
Milestone
1.20.4

Comments

@docwilmot
Copy link
Contributor

#130 removed the concept of global theme settings. Code comments on theme_get_setting() function needs to be updated to reflect this.
@ghost ghost mentioned this issue Oct 4, 2020
Merged
@ghost
Copy link

ghost commented Oct 4, 2020

How's this? backdrop/backdrop#3348

@indigoxela
Copy link
Member

Looks good.

Normally I'd request a rebase, but as this is a docblock-only change, which means, there's nothing to test, I'm fine with the PR as-is. RTBC 👍

(311 commits behind backdrop:1.x. - new record? 😀 )

@indigoxela indigoxela added this to the 1.20.4 milestone Dec 24, 2021
backdrop-ci referenced this issue in backdrop/backdrop Dec 27, 2021
Issue #451: Update documentation for theme_get_setting().
8ac00db 
By @BWPanda, @indigoxela, and @docwilmot.
backdrop-ci referenced this issue in backdrop/backdrop Dec 27, 2021
@quicksketch
Issue #451: Update documentation for theme_get_setting().
764dfa4 
By @BWPanda, @indigoxela, and @docwilmot.
@quicksketch
Copy link
Member

quicksketch commented Dec 27, 2021 •
edited
Loading

Thanks @BWPanda, @indigoxela, and @docwilmot! Wow, a 7 year old issue! Such a simple fix, and one less issue open. 😄

Merged in backdrop/backdrop#3348.

@quicksketch quicksketch mentioned this issue Jan 15, 2022
Closed
17 tasks
@jenlampton jenlampton changed the title Fix comment block on theme_get_setting() Fixed: Remove mention of global theme settings from docblock on theme_get_setting(). Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status - fixed type - task
Projects
None yet
Milestone
1.20.4
Development

Successfully merging a pull request may close this issue.

Issue #451: Update documentation for theme_get_setting().
5 participants
@quicksketch @jenlampton @indigoxela @docwilmot @Dinornis