-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed: remove non standard CSS property “zoom” #4276
Comments
Looks like it's used for IE7 support. Are we still supporting that...? |
Don't think so? Also, IE7 has 0.01% of market share, so probably safe to ax this line in the CSS. |
I don't have any strong opinion on this one. https://caniuse.com/#feat=css-zoom says that 93.79% of globally-used browsers support the property: It seems that it is supported by every current version of all popular browsers, with the exception of Firefox (4% global usage), Firefox mobile (0.23%), and Opera mini (0.69%) - so ~5% of users really. We could invoke our 3rd principle "Focus: Include features for the majority."
The oxymoron here is that we have this bit of code in place in order to serve a browser that has less than 0.02% usage: ...yet this error is thrown by browsers that are the least used globally - none of the popular browsers will complain about the usage of |
Yes, please let's get rid of that silly "zoom:" - the browser this workaround was necessary for is dead and gone for so long now. |
Thanks @laryn and @klonos. I've merged backdrop/backdrop#3145 into 1.x. |
I don't feel this is an important enough change to worry about also merging it into 1.19.4... |
Description of the bug
In the developer console I often see this on Drupal 7 and Backdrop sites:
The Mozilla docs say:
A search of the codebase suggests there's one usage of this in the
system.css
file. Do we need it?PR: backdrop/backdrop#3145
The text was updated successfully, but these errors were encountered: