Remove underline from Delete button in Basis

[ghost]

Description of the need
In the Basis theme, the Delete 'button' (on node edit forms) is actually a link styled to look like a button. As such, it has an underline which looks wrong considering the actual buttons it's styled after don't...

Steps to recreate

1. Visit admin/appearance
2. Choose Basis as Administration Theme (near bottom of page)
3. Go to admin/content
4. Edit any existing node and go to the bottom of the node edit form

Proposed solution
Remove the underline on the any links styled to look like buttons (a.button).

[jenlampton]

Great catch! :) I don't think this change needs designer feedback, so removing the design label.

[stpaultim]

@BWPanda - Whoops, I think that this has been fixed already.

I just spun up a new site and went to edit the "Your first post" post and I am not seeing this behavior. I'm also not seeing it on hover.

[ghost]

@stpaultim You need to turn off the admin theme for node forms to see this. E.g. uncheck 'Use the administration theme when editing or creating content' on the Appearance page.

[stpaultim]

I'm looking at this issue with the Open Source Day group.

[stpaultim]

Our proposed solution to this is the following CSS rule in Basis styles.css

a.form-delete {
  text-decoration: none;
}

We also considered

a#edit-delete {
text-decoration: none;
}

This seems specific enough that it should not break anything unexpected.

[himanshu007-creator]

This PR resolves the issue. Tested successfully

[jenlampton]

I added the "works for me" label yesterday thanks to the testing done by @himanshu007-creator (thank you).

The code also looks straightforward, RTBC!

[klonos]

This is a style inconsistency/bug. It can go in on a bug release.

[laryn]

Thinking out loud a bit here, but instead of pinpointing a.form-delete -- is this a change that should happen to any .button element? (Is there any button link implementation that should have an underline?)

[jenlampton]

Is there any button link implementation that should have an underline?

yes, probably. Sometimes we have cancel buttons that need to appear as though they are links -- but in those cases the cancel button is the one that should be targeted specifically.

[stpaultim]

OK, I did some poking around for another example of a button with an underline and found this on the dashboard.

This button would not have been fixed by the old PR but is fixed by this one.

[stpaultim]

@jenlampton - I don't usually assign people to issues, but THIS TIME it seemed appropriate! ;-)

[jenlampton]

Looks great! :) Thanks @stpaultim

[laryn]

Thank you for filing this @BWPanda, and for the PR, testing, and review @stpaultim, @himanshu007-creator, and @jenlampton! I've merged backdrop/backdrop#3667 into 1.x and 1.19.x.

[stpaultim]

@laryn - Thank you for spotting a better solution with broader implications.