Maintenance mode and updates via the UI

[laryn]

I believe in D7, when you update a module via the UI, you are prompted to put the site in maintenance mode, and then it automatically comes out of maintenance mode after the download is completed successfully. In Backdrop currently, it remains in maintenance mode until you go to manually turn it off.

---

PR by @laryn: backdrop/backdrop#2515

[laryn]

It looks like the intention is to take it out of maintenance mode automatically:

https://github.com/backdrop/backdrop/blob/c9ee437d06b1b9834c33229d3dd92ba9f8a14a14/core/modules/installer/installer.authorize.inc#L204-L210

[laryn]

Given the clear intent of the code and the fact that people who want a more extended maintenance mode can simply manually put it into maintenance mode before doing any updates (and it will stay in maintenance mode afterwards), I'm changing this to a bug.

[olafgrabienski]

I believe in D7, when you update a module via the UI, you are prompted to put the site in maintenance mode, and then it automatically comes out of maintenance mode after the download is completed successfully.

Confirming how it works in D7, see screenshot:

[serundeputy]

seems weird to me to take the site out of maintenance mode before you check if things are ok 🤷‍♀️ imho.

[herbdool]

Looks like a simple fix. I requested a small change @laryn

[laryn]

Thanks @herbdool -- good catch.

[jenlampton]

Code looks great, and testing showed that my site came out of maint mode :)

[quicksketch]

Merged backdrop/backdrop#2515 into 1.x and 1.14.x. Thanks folks!