Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[META][UX] Start using the new 'info' message type. #3312

Open
klonos opened this issue Oct 12, 2018 · 3 comments
Open

[META][UX] Start using the new 'info' message type. #3312

klonos opened this issue Oct 12, 2018 · 3 comments

Comments

@klonos
Copy link
Member

klonos commented Oct 12, 2018

In #3155 where this feature was implemented, we have identified some success (status) messages that would be better as info message instead. This issue if a follow-up to convert these, and perhaps other ones in core.


PR by @klonos: backdrop/backdrop#2318

@klonos
Copy link
Member Author

klonos commented Oct 12, 2018

...ok, initial PR up for review. I have only worked on messages on the Project Installer.

@klonos
Copy link
Member Author

klonos commented Oct 20, 2018

...I just filed another PR, in which I explore the option of adding some of the Project Installer messages in the Form level. The idea basically is to have messages with problems/info related to the form be closer to the thing they refer to, and to separate them from any possible "global" messages. Here's a before:

screen shot 2018-10-21 at 8 13 11 am

...and an after:

screen shot 2018-10-21 at 8 16 13 am

PS: shamelessly plugging #3329

@klonos klonos changed the title [UX] Start using the new 'info' message type. [META][UX] Start using the new 'info' message type. Oct 26, 2018
@klonos
Copy link
Member Author

klonos commented Oct 26, 2018

...I am making this a meta-issue.

@jenlampton jenlampton modified the milestones: 1.11.3, 1.11.4 Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants