Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Random LayoutInterfaceTest Failures in PHP 5.3 #3080

Closed
quicksketch opened this issue May 4, 2018 · 1 comment
Closed

Fix Random LayoutInterfaceTest Failures in PHP 5.3 #3080

quicksketch opened this issue May 4, 2018 · 1 comment

Comments

@quicksketch
Copy link
Member

Describe your issue or idea

We have some random failures coming from LayoutInterfaceTest in PHP 5.3 due to back-slashes in the title. We still have a JSON encoding problem in places but for now we should simply avoid this in our tests so we don't get random failures.

Fail      Other      layout.test       1240 LayoutInterfaceTest->testBlockUnins
"A testing block for layouts." found Exception ConfigStor config.inc        1041 ConfigFileStorage->read()          
The configuration file "layout.layout.tihrjljp" is not properly formatted JSON. Contents: { "_config_name": "layout.layout.tihrjljp", "path": "layout-test-path", "name": "tihrjljp", "title": "k\\\"m4k{ I","description":null,"module":null,"weight":0,"storage":1,"layout_template":"moscone_flipped","disabled":false,"settings":{"title":"","title_display":"default","title_block":null},"positions":{"header":["fddff427-8824-42ea-a408-8a2328467dd7","cd89f2e6-9e8d-4b42-a51f-31851bb3bab6"],"content":["83eb6f02-3fb6-4f74-ac00-c960901ced1b"],"footer":["8ee7b69e-3947-484c-a600-d0ec31547613"],"top":["48e8de5e-864e-4fb1-924d-777f76fe7225"]},"content":{"fddff427-8824-42ea-a408-8a2328467dd7":{"plugin":"system: header","data":{"module":"system","delta":"header","settings":{"title_display":"default","title":"","style":"default","block_settings":{"menu":"user-menu","logo":1,"site_name":1,"site_slogan":1},"contexts":[]},"uuid":"fddff427-8824-42ea-a408-8a2328467dd7","style":{"plugin":"default","data":{"settings":{"classes":""}}}}},"cd89f2e6-9e8d-4b42-a51f-31851bb3bab6":{"plugin":"system: 

image

From https://zen.ci/backdrop/backdrop/test/test-php53-backdrop_backdrop_2166-d6b349f-1

@quicksketch
Copy link
Member Author

Merged into 1.x and 1.9.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant