Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DX] Date and Link modules still uses $vars instead of $variables #3026

Closed
jenlampton opened this issue Apr 6, 2018 · 4 comments · Fixed by backdrop/backdrop#2605
Closed

[DX] Date and Link modules still uses $vars instead of $variables #3026

jenlampton opened this issue Apr 6, 2018 · 4 comments · Fixed by backdrop/backdrop#2605
Labels
good first issue status - fixed status - has pull request
Milestone
1.12.7

Comments

@jenlampton
Copy link
Member

jenlampton commented Apr 6, 2018 •
edited by klonos
Loading

Describe your issue or idea

It looks like our link module theme functions sill use the drupal-6 style shorthand $vars instead of the longer $variables the rest of core uses. We should fix this!

PR by @Plochem: backdrop/backdrop#2605
@opi
Copy link

opi commented Apr 7, 2018

git grep '&vars' told me that the Date module is still using $vars too.

docroot/core/modules/date/date.theme.inc:function template_preprocess_date_views_filter_form(&$vars) {

@opi opi changed the title [DX] Link module still uses $vars instead of $variables [DX] Date and Link modules still uses $vars instead of $variables Apr 7, 2018
@Plochem Plochem self-assigned this Apr 20, 2019
@Plochem Plochem mentioned this issue Apr 20, 2019
Merged
@Plochem Plochem removed their assignment Apr 20, 2019
@herbdool
Copy link

RTBC

backdrop-ci referenced this issue in backdrop/backdrop Apr 27, 2019
@Plochem @quicksketch
Issue #3026: changed $vars to $variables in Date and Link modules.
75b1b27 
By @Plochem and @herbdool.
backdrop-ci referenced this issue in backdrop/backdrop Apr 27, 2019
@Plochem @quicksketch
Issue #3026: changed $vars to $variables in Date and Link modules.
acb2a93 
By @Plochem and @herbdool.
@quicksketch
Copy link
Member

Thanks @Plochem for the PR! Looks great and I'm glad to see those abbreviated variables finally replaced. Merged into 1.x and 1.12.x.

@quicksketch quicksketch added this to the 1.12.7 milestone Apr 27, 2019
@klonos
Copy link
Member

klonos commented Apr 27, 2019 •
edited
Loading

Just noting that this PR included a change that belongs to #3608

@klonos klonos mentioned this issue Apr 27, 2019
Closed
@jenlampton jenlampton mentioned this issue May 16, 2019
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue status - fixed status - has pull request
Projects
None yet
Milestone
1.12.7
Development

Successfully merging a pull request may close this issue.

3026 vars to variables Plochem/backdrop
6 participants
@quicksketch @opi @jenlampton @herbdool @klonos @Plochem