Exceptions thrown when using PHP 7.2

[hosef]

In PHP 7.2, each() has been marked as deprecated and count() throws an exception when used on non countable types. These 2 behaviour changes cause a lot of errors in backdrop, and should be fixed.

---

PR by @hosef: backdrop/backdrop#2159

[herbdool]

This sounds useful @hosef. I see you closed your PR--are you going to create an updated one?

[hosef]

I made the original pull request from my main branch, which blocked me from working on other issues.
I will make a new branch and re-post the changes some time today.

[drupol]

Hi @hosef ,

Did you made a new PR ?

Thanks!

[hosef]

I was finally able to get back to this and I have a new pull request available based on the changes from https://www.drupal.org/project/drupal/issues/2947772.

I did not apply the Changes to Tar.php from Drupal because the Backdrop version did not have any of the errors updating. There were also several code differences between Drupal and Backdrop's versions, so I was not sure how to apply the changes.

[quicksketch]

Thanks @hosef! I read over the PR at backdrop/backdrop#2159 and it looks great. All changes make sense to me, though both the old and new syntaxes are a bit brain-melting. It's with good reason why such changes were made in PHP 7.2.

There were also several code differences between Drupal and Backdrop's versions, so I was not sure how to apply the changes.

I only found one missing change (other than the Tar classes) and that was in LocaleLanguageNegotiationInfoFunctionalTest. In Backdrop this was fixed in Issue #175: Simplifying config translation storage. So no change is needed there.

In Backdrop the updater and installer use Zip files (as that's what's hosted on GitHub) rather than Tar files, so we're not affected in the same way. However we do still use .tar files when downloading config exports.

@hosef Could you see if you can create a problem when visiting /admin/config/development/configuration/full/export and clicking the button there to export a full config archive in PHP 7.2? Likewise there may be problem when importing the config archives.

[hosef]

I tested the config export and it did have some errors, so I have applied the changes from https://www.drupal.org/project/drupal/issues/2946045 to system.tar.inc, and that allowed me to do a config export/import without errors.

[quicksketch]

Yay, that's great. Honestly I think we should use zip files for the config import/export as well and stop using tar files entirely, but for the purposes of this issue, we're all good here! Thanks so much for your work in porting this patch. All changes look good to me and all tests are passing. I am fairly sure we have complete coverage of all changes from the D7 patch where they apply to Backdrop.

[quicksketch]

I have merged backdrop/backdrop#2159 into 1.x and 1.9.x. Thanks @hosef!