"Add Existing Content" block doesn't respect the "Show author and date information" checkbox.

[herbdool]

Toggling the "Show author and date information" option does nothing from what I can see.

In Backdrop 1.6.0

---

PR: backdrop/backdrop#2047
PR by @herbdool backdrop/backdrop#2684

[Al-Rozhkov]

I can confirm this bug. When I watch variables in hook_preprocess_node, display_submitted is not overwritten and block flag is set to false.

[olafgrabienski]

I confirm the bug as well, it's still active in Backdrop 1.8.0.

As Rabbit Hole is being ported to fix Add a system of page-less nodes in contrib, there are new use cases for "Add existing content" blocks, and this bug will concern more sites in the future. @Al-Rozhkov are you still/again up to have look at the issue?

[Al-Rozhkov]

Unfortunately I don't have time to work on this. Anybody can pick this up.

[serundeputy]

Added PR to check for NodeBlock in node_view() and then check display_submitted from the block form.

Website: http://2047.backdrop.backdrop.qa.backdropcms.org
Username: admin
Password: Lci5EopL

[herbdool]

@serundeputy works!

[serundeputy]

Updated PR fixing test failures.

[quicksketch]

The PR looks like it would work but it's mixing the data model (the $node object) with the display information (by setting $node->display_submitted). It shouldn't matter where the node is being rendered, the $node object should always just contain the node data. Instead we should be passing a variable to theme('node'), or in our case because this is a renderable, as $content['#display_submitted'] = TRUE;

We're already doing this, but it looks like this value might be getting wiped out in template_preprocess_node(). Could you take another look at this @serundeputy?

Code review comments: backdrop/backdrop#2047 (review)

[herbdool]

The issue was that it was assuming the node was using a view_mode == "block" when actually the user can set it to anything. I've come up with a small PR backdrop/backdrop#2684. Maybe @olafgrabienski you feel like testing? Thanks!

[olafgrabienski]

@herbdool Thanks for the new PR! It's working in the sandbox site, test page: http://2684.backdrop.backdrop.qa.backdropcms.org/about.

[herbdool]

PR approved by @serundeputy

[quicksketch]

Looks great! Nice and simple. Merged backdrop/backdrop#2684 into 1.x and 1.13.x.