Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DX] Remove confusion around view mode "custom_settings" vs "custom settings" #2449

Open
jenlampton opened this issue Jan 2, 2017 · 1 comment
Open

[DX] Remove confusion around view mode "custom_settings" vs "custom settings" #2449

jenlampton opened this issue Jan 2, 2017 · 1 comment
Labels
needs - more feedback type - task

Comments

@jenlampton
Copy link
Member

jenlampton commented Jan 2, 2017 •
edited
Loading

See underscores in field_view_mode_settings() vs spaces in entity_get_info().

From @quicksketch :

Sometimes a view mode has the property custom settings and sometimes custom_settings. This inconsistent use of underscores is terribly confusing. Is this something we've inherited, or can we fix this?
This was referenced Jan 2, 2017
Merged
Closed
@jenlampton jenlampton changed the title Remove confusion around view mode "cusom_settings" vs "custom settings" [DX] Remove confusion around view mode "cusom_settings" vs "custom settings" Jan 2, 2017
@klonos klonos changed the title [DX] Remove confusion around view mode "cusom_settings" vs "custom settings" [DX] Remove confusion around view mode "custom_settings" vs "custom settings" Jan 15, 2017
@klonos
Copy link
Member

klonos commented Jan 15, 2017

...missing "t" there in "custom settings" 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs - more feedback type - task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jenlampton @klonos