-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure dropdown menu #2367
Comments
There is no setting yet afaik, but you could override the relevant CSS definition as a workaround. If your site runs with the Basis theme, in
Overriding the min-width value for this
The hamburger menu didn't make it in the release but I understood that it should be added. See the issue summary on #2107 (comment) and @quicksketch's proposal in #2107 (comment):
I'm not aware that such a implementation has started. Does anybody know? (@quicksketch @klonos @wesruv) If not we should create an issue to add the missing hamburger menu setting.
What would you prefer here? A setting to change the behaviour, or just a different behaviour, and which one? Links:
|
Thanks for the response @olafgrabienski
I understand that this is what some people are used to, so I'd like at least the option to change this behaviour to one of the following:
|
In my opinion, both of the options are reasonable. @BWPanda Could you make a feature request only for the parent menu behaviour issue and mention it's a follow-up of #2107 like @klonos did in #2160 and #2161? We can then discuss there which behaviour makes more sense, and if it should be an option or by default. I'll make a separate issue regarding the hamburger menu, probably tomorrow. |
@olafgrabienski I pulled out some of the earlier Gitter conversation about the hamburger into an issue here: |
@laryn Perfect, thanks for being faster! |
Re: changing the breakpoint for the responsive menu via code, I had a thought for that. The "no js" experience would be what it is now, in order to change it you override the stylesheet for the menu. We'd also add The default JS experience would auto-detect when the menu doesn't fit in it's space and turn to responsive version then. Thinking we'd have a lightweight script that checked to see if the last menu item is wrapping and if so apply a class. That class would do what the media query is currently doing, but they wouldn't be inside of any media query. We could add a configuration setting for the width the menu should change to desktop version, the JS that would have auto-detected could check to see if that setting is set before it does any of it's work and use the static width instead of the menu's width. Though I'm not sure how much people will want to use that if the menu can auto-detect. The auto-detection stuff is currently being done in the responsive admin tabs that are in Seven and Basis, I believe the code has been abstracted to the point where we can use the same functionality for the responsive menu and the admin tabs. |
Thanx for filing the follow-up issues guys. Still trying to catch up with the queue. |
I think what questions I had have either been answered, or subsequent issues opened. So closing this issue now. |
I'm wondering how to configure the dropdown menu in BD core? It changes to a 'mobile' menu at around 768px, but I want to change that to be smaller. Also, there's no 'hamburger' menu option; all menu items are shown by default on small screens. Finally, when you have a parent menu item that you want to click on, you have to essentially double-click on it - once to expand the children, and then again to navigate to the parent link's URL. At the same time, the children disappear, so it seems that clicking the parent the second time simply closes the child menu, until you're taken to the parent's URL and you're left wondering what happened.
I guess I'm used to Superfish for Drupal and being able to configure all these things, so maybe this is a feature request...
The text was updated successfully, but these errors were encountered: