Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the file entity a classed object #152

Closed
quicksketch opened this issue Jan 7, 2014 · 4 comments
Closed

Make the file entity a classed object #152

quicksketch opened this issue Jan 7, 2014 · 4 comments

Comments

@quicksketch
Copy link
Member

Sub-issue of #49. Currently Backdrop uses "real" objects only for Comments, since Backdrop was forked just after https://drupal.org/node/1184944, which added the initial conversion of entities into real objects with CRUD support.

Files entities are currently owned by System module. After completing this conversion, it's likely we will follow D8's suit here and move the hook_entity_info() for files into File module after this conversion.

Drupal.org issue: https://drupal.org/node/1361226

@quicksketch
Copy link
Member Author

I've started a port of the File entity class at https://github.com/quicksketch/backdrop/compare/152;file_classes?expand=1.

This includes the primary patch at https://drupal.org/node/1361226 as well as the prerequisite from https://drupal.org/node/1401558. We'll see how Travis reports on the tests and then make an official PR.

@quicksketch
Copy link
Member Author

Tests are now passing on this PR: backdrop/backdrop#132.

@quicksketch
Copy link
Member Author

Let's merge this in so we can move forward with cleaning up the APIs associated with all entity types in #164.

@quicksketch
Copy link
Member Author

backdrop/backdrop#132 has been merged in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants