Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider converting the watchdog list to a view. #1302

Open
klonos opened this issue Oct 9, 2015 · 7 comments
Open

Consider converting the watchdog list to a view. #1302

klonos opened this issue Oct 9, 2015 · 7 comments

Comments

@klonos
Copy link
Member

klonos commented Oct 9, 2015

I'm filing this as a candidate sub-issue of the #151 META...

There's the Views Watchdog module for Drupal that does this (could be others too) and we can use that as a starting point. I imagine that the "Top 'access denied' errors" (/admin/reports/access-denied) and the "Top 'page not found' errors" (/admin/reports/page-not-found) report pages can then simply be filtered versions of the same view and on top of that we can expose whichever of these views/displays as blocks that can be then used in #495 to create a (highly customizable may I add) dashboard.

Thoughts?

@sutibun
Copy link
Member

sutibun commented Oct 9, 2015

hehe Watchdog... that's a cute name.

thoughts? uh.... yeah... that's all I got.

Wait... I do have a question just because I am curious. Generally speaking, why the move to Views?

@klonos
Copy link
Member Author

klonos commented Oct 9, 2015

...why the move to Views?

  1. For starters, these listings would have been views in the first place if views was in core when they were implemented. Now with views in core, it is the time to do it. Previously, this move would essentially mean that we would be forcing people to need to install a contrib module (Views).
  2. Using views means reusing (generalized) code to do similar things as opposed using custom code for each separate listing. This brings other advantages too because if we improve something in views (say speed for example), then that improvement propagates all over the UI.
  3. Customizability (auto correction says this word is wrong - did I just make it up?): If people don't like how an admin listing is displayed out of the box (which columns, the order of the columns etc.), they can easily customize it to their liking (using the Views UI). When these were not views, people had to file an issue in the queue in order to request a change, then pray that their change proposal gets accepted, then wait for a patch to be coded by someone, then wait a few years for the patch to be merged in core before they see their change happen.

Enough reasons?

@klonos
Copy link
Member Author

klonos commented Oct 9, 2015

...usually, I like to present some stats to back my case. The Administration Views module (that essentially does what we are trying to implement in core but for D7) counts some 90k 7.x installations while Drupal 7 counts about one million. So in this specific case, it is roughly 10% - not a 80/20 use case that usually justifies implementing a new feature. My explanation to this fact is that people simply are not aware of the existence of Administration Views.

@sutibun
Copy link
Member

sutibun commented Oct 9, 2015

Ah, kk.

hehe no stats needed. I just wanted to understand for myself. There wasn't an explanation in that other ticket (151) you linked to and it was like everything was going into Views. Seemed like there was some Drupal backstory behind that that I was missing (really didn't participate in the Drupal community before) and you look like you've been through it all in Drupal.

@klonos
Copy link
Member Author

klonos commented Mar 22, 2016

@ghost
Copy link

ghost commented Mar 24, 2016

1.x-1.1.0 released.

For more information and how-to's, see the online handbook entry at
https://github.com/backdrop-contrib/views_watchdog/wiki

@mikemccaffrey
Copy link

Are watchdog items entities? Should we be converting them to entities?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants