Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change name pattern of download files #32

Open
olafgrabienski opened this issue Apr 23, 2019 · 1 comment
Open

Change name pattern of download files #32

olafgrabienski opened this issue Apr 23, 2019 · 1 comment
Assignees

Comments

@olafgrabienski
Copy link

The name pattern for download files on the translation server is backdropcms-VERSION.LANGCODE.po. @quicksketch wrote in backdrop/backdrop-issues#3674 (comment):

it raised my eyebrows that the name of the downloaded file was "backdropcms" instead of just "backdrop". Inside our own codebase, we always use the shortened version without "cms" for function names, settings, etc.

When backdrop/backdrop-issues#3674 is fixed, let's drop the cms part of the name pattern and change it to backdrop-VERSION.LANGCODE.po.

@olafgrabienski
Copy link
Author

In the meantime, backdrop/backdrop-issues#3674 has been fixed, so we can drop the cms part of the file names. There was however another core issue (backdrop/backdrop-issues#3974) with translation file names recently. I'd prefer to wait with the name pattern change here until the recent core issue is fixed and part of a new Backdrop release. We should test then, if Backdrop can still be installed with a language other than English (as expected).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant