Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Views proximity filter and field: replace #dependency with #states #36

Closed
herbdool opened this issue Jan 8, 2023 · 4 comments · Fixed by #38
Closed

Views proximity filter and field: replace #dependency with #states #36

herbdool opened this issue Jan 8, 2023 · 4 comments · Fixed by #38
Labels
bug has pr

Comments

@herbdool
Copy link
Contributor

herbdool commented Jan 8, 2023 •
edited
Loading

I'm going to add more detail soon, but for now I'd like to just not that the views filter and field are not working. The states seem to be broken at the least.

Update: I'm pretty sure it's because #dependency no longer does anything in Views under Backdrop. I believe elsewhere in core Views they were replaced with #states so we should do that here too. Funnily geofield_proximity_manual already uses #states so can just use that example for all the other plugins.
@herbdool herbdool added the bug label Jan 8, 2023
@herbdool herbdool changed the title Views proximity filter and field not working Views proximity filter and field: #dependency no longer works Jan 10, 2023
@herbdool
Copy link
Contributor Author

Here's the issue where this happened: backdrop/backdrop-issues#40

@herbdool herbdool changed the title Views proximity filter and field: #dependency no longer works Views proximity filter and field: replace #dependency with #states Jan 10, 2023
@herbdool herbdool mentioned this issue Jan 10, 2023
Merged
@herbdool
Copy link
Contributor Author

@jenlampton @earthday47 I've got a simple PR to fix the UI for proximity field/filter in Views. #38

@herbdool herbdool added the has pr label Feb 2, 2023
@herbdool
Copy link
Contributor Author

herbdool commented Feb 2, 2023

@jenlampton reminder about this easy fix in my PR

@argiepiano
Copy link
Contributor

@herbdool I've tested and LGMT!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug has pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #35: replace dependency with states herbdool/geofield
2 participants
@herbdool @argiepiano