Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP8.1 compat: undefined properties in EntityPlusController #170

Open
herbdool opened this issue Feb 26, 2024 · 1 comment
Open

PHP8.1 compat: undefined properties in EntityPlusController #170

herbdool opened this issue Feb 26, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@herbdool
Copy link
Contributor

These should be defined in EntityPlusController:

  • cache (maybe as private since it says it's for BC)
  • statusKey

It also calls db_ignore_slave() which should be db_ignore_replica() now.
@herbdool herbdool added the bug Something isn't working label Feb 26, 2024
@argiepiano
Copy link
Collaborator

Thanks for reporting, @herbdool. These changes all look good. Would you like to submit a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@herbdool @argiepiano