Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coder_upgrade_upgrade_regex_info_alter() assumes .info file belongs to module, but can also be a theme #63

Open
klonos opened this issue Dec 18, 2021 · 0 comments
Labels

Comments

@klonos
Copy link
Member

klonos commented Dec 18, 2021

Not sure exactly how to best do it, but at some point I think that we should implement something like this:

Change this:

function coder_upgrade_upgrade_regex_info_alter(&$file) {
...
  $to[] = "backdrop = 1.x\ntype = module";
...
}

...to something like this:

function coder_upgrade_upgrade_regex_info_alter(&$file, $type = 'module') {
...
  $to[] = "backdrop = 1.x\ntype = $type";
...
}

Then we need to figure out how to best detect whether we are converting a module of theme .info file, and where/how to pass $type accordingly.

Here's some info that might help (see: https://www.drupal.org/docs/7/theming/writing-theme-info-files#s-theme-name-requirements):

Theme .info files in Drupal 7 are required to have a name = and a core = entry (same as modules), but they may also contain entries for:

  • engine: (optional, defaults to phptemplate)
  • regions[]: (optional, with defaults provided by D7 core)
  • stylesheets[]: (required in D7) an array of all .css files you want the theme to use.
  • scripts[]: (required in D7) an array of all .js files you want the theme to use.
  • features[]: (optional) for page elements that can be toggled on/off, such as site logo/name/slogan/favicon/main_menu/secondary_menu etc.
  • settings[]: (optional) if these entries exist, there should also be a theme-settings.php file in the root folder of the theme.
@klonos klonos added the bug label Dec 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant