Some gotchas

[herbdool]

There are a few gotchas which users should be aware of. Some of them can be fixed, others should have warnings. Currently using coder_upgrade could be misleading developers.

Bugs:

• Deletes __DIR__
• Needs $config->save() in upgrade hook
• Replaces Drupal even if in a URL
• Forces TRUE/FALSE to be strings in config file.

Misleading:

• If a config variable should instead be in state_get, users need to be aware. Perhaps a warning in the README file.

[bugfolder]

PR 32 fixes the missing $config->save() in upgrade hook.

[bugfolder]

PR 42 fixes "Forces TRUE/FALSE to be strings in config file.".

[roxy-jaqkar]

Trying to convert Bundle Copy module with Coder Upgrade and running into problems. The module is not recognizing my folders (new/old/patch). Have checked permissions, cleared cache and run cron to no avail. Any ideas?

[docwilmot]

Strange. To be clear, you placed the module folder to be converted into SITE_ROOT/files/coder_upgrade/old and not SITE_ROOT/modules/coder_upgrade/old ?

[roxy-jaqkar]

Yes, path is: site_root/files/coder_upgrade/old. I uploaded a zip file.

[docwilmot]

Ahh no, not a zipped file, upload the actual folder.

[roxy-jaqkar]

OK, will try that. Thanks!

[bugfolder]

Bringing this back on-topic, the two remaining open bugs from this issue are (adding checkboxes to check them off as they get addressed):

• ... | Deletes __DIR__
• ... | Replaces Drupal even if in a URL