Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: filter undefined options #500

Merged
merged 1 commit into from
Sep 26, 2023
Merged

fix: filter undefined options #500

merged 1 commit into from
Sep 26, 2023

Conversation

runspired
Copy link
Contributor

@runspired runspired commented Aug 27, 2023 •
edited
Loading

resolves #499

PR with a patch demonstrating this fix for EmberData emberjs/data#8800

@runspired
Copy link
Contributor Author

looks like there was a dependency installation timeout on the two failing scenarios and they just need a kick.

@NullVoxPopuli
Copy link
Contributor

NullVoxPopuli commented Aug 27, 2023 •
edited
Loading

Any chance you'd be willing to add a test for this? in particular, around here: https://github.com/babel/ember-cli-babel/blob/master/node-tests/addon-test.js#L1689

I did a search for babel: in the tests, and found few -- but all had options specified, so the undefined config scenario isn't covered

@ef4 ef4 added the bug label Sep 26, 2023
@ef4 ef4 merged commit 9d0a082 into emberjs:master Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertdeblock bertdeblock bertdeblock approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ember-cli-babel@8 breaks parallelization
4 participants
@runspired @NullVoxPopuli @bertdeblock @ef4