Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for the includePolyfill option #458

Merged
merged 2 commits into from
Oct 7, 2022

Conversation

bertdeblock
Copy link
Member

@bertdeblock bertdeblock commented Oct 1, 2022

@babel/polyfill is deprecated, the replacement for users would be to include core-js/stable directly:

// app.js

import 'core-js/stable';

Builds on #454, as running ember test wasn't working for me locally, because of the macOS + Ember CLI issue.

Related to #453.

@bertdeblock bertdeblock self-assigned this Oct 1, 2022
@bertdeblock bertdeblock mentioned this pull request Oct 1, 2022
10 tasks
@bertdeblock bertdeblock force-pushed the drop-include-polyfill-support branch from be7dc9c to b9af43a Compare October 1, 2022 19:52
@bertdeblock bertdeblock force-pushed the drop-include-polyfill-support branch from b9af43a to 079960e Compare October 6, 2022 14:41
@bertdeblock bertdeblock changed the title Drop includePolyfill support Drop support for the includePolyfill option Oct 6, 2022
@bertdeblock bertdeblock requested a review from ef4 October 6, 2022 15:15
@rwjblue rwjblue merged commit 7247fb7 into emberjs:master Oct 7, 2022
@@ -52,7 +52,6 @@
"@babel/plugin-transform-modules-amd": "^7.13.0",
"@babel/plugin-transform-runtime": "^7.13.9",
"@babel/plugin-transform-typescript": "^7.13.0",
"@babel/polyfill": "^7.11.5",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants