Include addon name directory in 'treeForAddon' (mitigate issues with Embroider when using external helpers) #394
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Info
treeForAddon
method provided byember-cli
ensures that all compiled assets are put into a directory named after the addon itself (see https://github.com/ember-cli/ember-cli/blob/9911f5493c00986ac2d0be104a80152426240a30/lib/models/addon.js#L1196)treeForAddon
method, however,ember-cli-babel
currently doesn't do that for the babel helpers.Changes
Funnel
that includes the addon module name directory when building the Babel helpers (using the samemoduleName
method that the base addon class uses.