Update babel plugins and pin to @babel/[email protected]

[patocallaghan]

Upgrading all babel-plugin-* dependencies due to conversation in #382 (comment)

• @babel/plugin-proposal-decorators
• @babel/plugin-transform-modules-amd
• @babel/plugin-transform-runtime
• @babel/plugin-transform-typescript
• babel-plugin-ember-modules-api-polyfill

It also pins @babel/runtime to 7.12.18 to workaround test failures in CI for the "Floating dependencies" scenario.

/cc @rwjblue

[rwjblue]

Can you also update package.json to use those new minimum versions as well?

[patocallaghan]

Updated the package.json 👍

[rwjblue]

Hmmm. Something is causing the floating dependencies tests to time out.

[patocallaghan]

@rwjblue seeing this in CI. Will have a dig later

[rwjblue]

Seems like the same thing being reported in later comments over in #384

[patocallaghan]

Interesting, so bumping a few other babel-related deps has caused the issue to manifest in the non-"floating dependencies" tests. Unfortunately it's only happening in CI for me, I can't reproduce locally, so will need to rollback each of those upgrades I just did one-by-one.

[rwjblue]

I've canceled some of the CI runs (to try to get faster turn around)

[patocallaghan]

@rwjblue it's not pretty but I've pinned @babel/runtime to 7.12.18 and that resolves the floating dependencies issue. I haven't bottomed-out out on it yet but it appears to be related to babel/babel#12881. This issue was closed but bumping to the latest babel/runtime caused it to still happen.

Unfortunately as I stated earlier, I can only reproduce the issue on CI which makes debugging a bit painful.

[boris-petrov]

FWIW I also had to pin @babel/runtime in my app to 7.12.18 but only because of an "old" targets.js. Using:

[
  'chrome >= 85',
  'edge >= 85',
  'firefox >= 80',
  'safari >= 14',
]

Works fine with @babel/runtime 7.13.9+ but using ['firefox 35'] for targets leads to the error and I have to use 7.12.18 because of that. Just to mention it, not sure if it's relevant here.

[patocallaghan]

Thanks @boris-petrov, that could well be the case here as we add ie11 in CI.

https://github.com/babel/ember-cli-babel/blob/20924faa529cf4f9c6f7cb8fa2c89d968184b620/tests/dummy/config/targets.js#L3-L14

I guess we should keep it pinned though as officially the Ember framework still supports IE11 (until 4.0 anyway)?

[boris-petrov]

Yep, that seems to be the same issue as mine. Well, yes, for now it's better to pin. I will be trying from time to time to update and I'll be sure to let you know if a 7.13.x or later version works so you can unpin. Or you can find and fix the underlying cause. 😄 I'm not sure where it could be though.