Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @babel package to latest (generally 7.9.0) #330

Merged
merged 2 commits into from
Mar 23, 2020

Conversation

jamescdavis
Copy link
Contributor

Update @babel/* dependencies to latest (generally 7.9.0).

This ensures that ember-cli-babel will use a version of Babel that includes babel/babel#11129 (included in 7.8.7) and TypeScript 3.8 support (included in 7.9.0) as well as other fixes and improvements included in Babel 7.9.0.

@jamescdavis
Copy link
Contributor Author

Tests pass locally 🤔

@nicolo-ribaudo
Copy link
Collaborator

nicolo-ribaudo commented Mar 21, 2020

The bug on Travis is present in @babel/preset-env from version 7.8.0 to version 7.8.6. I don't know why it's included here 🤔


EDIT: https://github.com/jamescdavis/ember-cli-babel/blob/32f6061514175f781f7f6399b89c560cc82ff668/yarn.lock#L770

Maybe try running npx yarn-deduplicate

@jamescdavis
Copy link
Contributor Author

Thanks @nicolo-ribaudo, that worked!

@rwjblue rwjblue merged commit d1ff8f0 into emberjs:master Mar 23, 2020
@rwjblue rwjblue changed the title chore: update @babel/*@latest (generally 7.9.0) Update @babel package to latest (generally 7.9.0) Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants