Use default targets configuration for transpilation tests. #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In @babel/[email protected] 3 new plugins are added when supporting < IE 11: * transform-member-expression-literals * transform-property-literals * transform-reserved-words Unfortunately, babel-plugin-ember-modules-api-polyfill does a "bad thing" and updates the imported identifiers value to **be** a string like `Ember.Foo` which is completely invalid. The new transforms added in @babel/[email protected] (correctly) try to fix invalid identifiers for IE9/IE10 and end up making the output completely incorrect. This commit adds targets to prevent these plugins from being used in our own test harness, but we should **absolutely** fix the underlying issue upstream in babel-plugin-ember-modules-api-polyfill.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In @babel/[email protected] 3 new plugins are added when supporting < IE 11:
Unfortunately, babel-plugin-ember-modules-api-polyfill does a "bad thing" and updates the imported identifiers value to be a string like
Ember.Foowhich is completely invalid. The new transforms added in @babel/[email protected] (correctly) try to fix invalid identifiers for IE9/IE10 and end up making the output completely incorrect.This commit adds targets to prevent these plugins from being used in our own test harness, but we should absolutely fix the underlying issue upstream in babel-plugin-ember-modules-api-polyfill.
Fixes #281
Closes #282