Ensure external helpers are not used when modules are not transpiled. #267
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using something akin to the following somewhat common pattern:
The previous logic would still attempt to use external helpers even when modules themselves are not being transpiled. This meant that the final output would include untranspiled
import
statements.This affects common addons such as:
The fix here is to detect that modules will not be compiled, and avoid usage of the external helpers.
This also moves the validation that parent addon's do not specify
includeExternalHelpers
in their own config to the sharedgetAddonConfig
method (and makes the logic in that method a bit easier to grok).Fixes ember-polyfills/ember-modifier-manager-polyfill#4