Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a no-op optimization #204

Merged
merged 2 commits into from
Feb 27, 2018
Merged

Conversation

kellyselden
Copy link
Member

Closes #201

@stefanpenner
Copy link
Member

stefanpenner commented Feb 22, 2018

@kellyselden I like this, but can you add a quick unit test for that hook, ensuring that this works as expected (and continues to into the future)

@kellyselden
Copy link
Member Author

@stefanpenner added a test

Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, can you add a test that roughly does:

        subject = this.addon.transpileTree(input.path(), {
          'ember-cli-babel': {
            compileModules: false,
            disablePresetEnv: true,
            disableDebugTooling: true,
            disableEmberModulesAPIPolyfill: true
          }
        });

         expect(subject).to.equal(input.path());

@kellyselden
Copy link
Member Author

@rwjblue That's essentially what my test is. What would you like changed?

@stefanpenner stefanpenner merged commit fd6c9a6 into emberjs:master Feb 27, 2018
@stefanpenner
Copy link
Member

released as v6.12.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants